Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested urlnames #7

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Add support for nested urlnames #7

merged 1 commit into from
Oct 23, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 23, 2020

We are able to request nested urlnames now as well. Before we only support top level urlnames.

@tvdeyen tvdeyen requested review from mamhoff and removed request for mamhoff October 23, 2020 14:52
@tvdeyen tvdeyen self-assigned this Oct 23, 2020
@tvdeyen tvdeyen marked this pull request as draft October 23, 2020 14:59
@tvdeyen
Add support for nested urlnames
acb3e30 
We are able to request nested urlnames now as well. Before we only support top level urlnames.
@tvdeyen tvdeyen force-pushed the add-support-for-nested-urlnames branch from bf068d0 to acb3e30 Compare October 23, 2020 15:09
@tvdeyen tvdeyen marked this pull request as ready for review October 23, 2020 15:29
@tvdeyen tvdeyen requested a review from mamhoff October 23, 2020 15:29
@tvdeyen tvdeyen removed their assignment Oct 23, 2020
mamhoff
mamhoff approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's nice!

@tvdeyen tvdeyen merged commit d7b33a7 into production Oct 23, 2020
@tvdeyen tvdeyen deleted the add-support-for-nested-urlnames branch October 23, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @mamhoff